Funcky analyzer #397
Merged
Funcky analyzer #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We want to give a hint for Enumerable.Repeat("value", 1) to replace with Sequence.Return("value")
* And of course: None() -> None in Funcky 3.0
* Tried to implement a fix * Tried to get the test running
Extract MatchArgument to the SyntaxMatcher
bash
requested changes
Jul 28, 2021
Funcky.Analyzer/Funcky.Analyzer.CodeFixes/Funcky.Analyzer.CodeFixes.csproj
Show resolved
Hide resolved
Funcky.Analyzer/Funcky.Analyzer.CodeFixes/EnumerableRepeatNeverCodeFix.cs
Outdated
Show resolved
Hide resolved
Funcky.Analyzer/Funcky.Analyzer.CodeFixes/EnumerableRepeatNeverCodeFix.cs
Outdated
Show resolved
Hide resolved
…rCodeFix.cs Prefer MinimalDisplayString see: https://stackoverflow.com/questions/8231211/get-typesyntax-from-itypesymbol Co-authored-by: Ruben <4602612+bash@users.noreply.github.com>
…into funcky-analyzer
bash
reviewed
Jul 30, 2021
Funcky.Analyzer/Funcky.Analyzer.Vsix/source.extension.vsixmanifest
Outdated
Show resolved
Hide resolved
…fest improve description of vsix Co-authored-by: Ruben <4602612+bash@users.noreply.github.com>
bash
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggest
Sequence.Return(x)when code isEnumerable.Repeat(x, 1)suggest
Enumerable.Empty<T>()when code isEnumerable.Repeat(x, 0)