Skip to content

add rest and ws specs #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2022
Merged

add rest and ws specs #189

merged 1 commit into from
May 18, 2022

Conversation

morningvera
Copy link
Contributor

No description provided.

@morningvera morningvera requested a review from jbonzo May 18, 2022 16:29
clickingbuttons
clickingbuttons approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@clickingbuttons clickingbuttons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that we support all these exactly, but LGTM!

@jbonzo
Copy link
Collaborator

jbonzo commented May 18, 2022

I don't know that we support all these exactly, but LGTM!

Have we not audited this repo against our docs?

@morningvera
Copy link
Contributor Author

@jbonzo yeah, we've audited it against the docs. probably going to take a final look before releasing v1 though

@morningvera morningvera merged commit 277ad78 into master May 18, 2022
@morningvera morningvera deleted the v.spec branch May 18, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbonzo jbonzo Awaiting requested review from jbonzo

1 more reviewer

@clickingbuttons clickingbuttons clickingbuttons approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morningvera @jbonzo @clickingbuttons