feat: add type annotations to modelclass #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinpolygon
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
LGTM - Overall, the changes seem to be very thoughtful improvements. The main change is the addition of type annotations, which can provide better support for IDEs, linters, and type checkers. This is generally a good practice, as it can make the code more self-documenting and can catch potential type-related errors earlier in the development process. I have run through all the examples for stocks, options, indices, forex, and crypto. Nothing breaks. Thanks for your detailed issue and the PR! Cheers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #424