Fetch request records in batch v1 results

[jc]

See polytomic/app#7256

[nyergler]

I think you can also get rid of 243-248 since requestRecords will always have been fetched.

[nyergler]

I wonder if this should just be Record (rather than "Unprocessed"). Although I suspect it's the former due to embedding, so maybe not an easy/small change.

[jc]

I'm a little unsure about this comment.

Are you saying:

		jobRecord := bulk.JobRecord{
			ID: record.ID,
		}
		if record.Success {
			jobRecord.Fields = fields
		} else {
			jobRecord.UnprocessedRecord.Fields = fields
                }

Aren't they equivalent? Since Fields can be accessed either directly on JobRecord or through JobRecord.UnprocessedRecord?

type JobRecord struct {
	ID string
	UnprocessedRecord
}

[nyergler]

I was saying that UnprocessedRecord is sort of a misnomer; it's really Record. So you could image the JobRecord type looking like:

type JobRecord struct {
	ID string
	Record UnprocessedRecord
}

At which point you say, why not just rename UnprocessedRecord to Record.

More of an observation/musing than a request for this PR.