-
Notifications
You must be signed in to change notification settings - Fork 3
feat: config bundle packages #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All-in-all looks good. Feel free to dismiss my proposition for changes if you disagree with them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general nit I have with our project structure is that we inline a lot of these exports under “index.ts”, instead of having them in separate files. My main reason for wanting to have an export by file (and it doesn’t have to be a default export) is that it makes it easier to locate types by filename, especially when reviewing code.
Is there any particular reason for us not doing something like this?
Again, this is just a nit 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To help me better understand, can you highlight where this is happening?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Features
@polywrap/client-config-builder-js
DefaultBundle
has been broken apart into two separate bundles:sys
andweb3
.addBundle(...)
has been added to theClientConfigBuilder
interface.addDefaults()
now callsaddBundle("sys")
andaddBundle("web3")
internally.@polywrap/sys-config-bundle-js
logger
,datetime
,concurrent
,http
,httpResolver
fileSystem
,fileSystemResolver
.@polywrap/web3-config-bundle-js
ethereumProviderV1
,ethereumProviderV2
,ipfsHttpClient
,ipfsResolver
,ensTextRecordResolver
,ensResolver
,ensIpfsContenthashResolver
.@polywrap/config-bundle-types-js
bundle
value, which is of typeBundle
.Bugs
@polywrap/client-js