Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSITerm bug: SIGWINCH does not exist on Windows #1764

Closed
jtfmumm opened this issue Mar 28, 2017 · 0 comments
Closed

ANSITerm bug: SIGWINCH does not exist on Windows #1764

jtfmumm opened this issue Mar 28, 2017 · 0 comments

Comments

@jtfmumm
Copy link
Contributor

jtfmumm commented Mar 28, 2017

In the ANSITerm constructor, a signal handler is set up that does not work on Windows,
as seen in this snippet from the file:

  new create(notify: ANSINotify iso, source: DisposableActor,
    timers: Timers = Timers)
  =>
    """
    Create a new ANSI term.
    """
    _timers = timers
    _notify = consume notify
    _source = source

    // Windows explodes in a swarm of tiny window fragments
    SignalHandler(recover _TermResizeNotify(this) end, Sig.winch())

    _size()

I've opened a PR where I ifdef this line out for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant