Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: double click to maximzie #647

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

leb-kuchen
Copy link
Contributor

should fix #333
This updates libcosmic to pop-os/libcosmic@8e67f3c.
Text has a new field wrap.

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this does look good code-wise, have you confirmed this works well not only with server-side decorations, but the other ways in which we use libcosmic in cosmic-comp?

Please make sure there are no obvious visual issues with the window header context menu (shown on right-click for either csd or ssd windows, stacks, resize indicators (shown on Super+R), swap indicators (shown on Super+X, when moving to a different window), stack indicators (shown when dragging a window on top of another window in tiling mode).

In any case thanks for working on this!

@leb-kuchen
Copy link
Contributor Author

I have not noticed any obvious regressions, but I have not used this patch on a daily basis, so I can only give you information from a few minutes of testings.

@Drakulix
Copy link
Member

I have not noticed any obvious regressions, but I have not used this patch on a daily basis, so I can only give you information from a few minutes of testings.

That is fine. I'll do some further testing.

@Drakulix Drakulix force-pushed the double-click-maximize branch from d475fd4 to 2243220 Compare July 26, 2024 11:22
@Drakulix Drakulix merged commit 3214ef0 into pop-os:master Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server-side decorations: double click to maximize window
2 participants