-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resize window with Super + Right-Click Drag #664
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up! Looks pretty good apart from some minor nitpicks.
If a app window has another window above it, you cannot do a horizontal drag in the top quandrants, likewise if there is a window below it, a bottom quadrant drag does not work. if you have applications surrounding an app on all sides, horizontal adjustment seems impossible. |
Is this in the tiling mode? I'm not sure how to reproduce this. On a maybe-related note, it looks like dragging tiling windows only works on one axis at a time (this also applies to dragging directly with the cursor on the corner). |
Correct, it is in tiling mode, also can verify the exact same behavior when clicking the corner, it only effecting vertical resizing. |
Yep, I can confirm now. That is a separate issue, which affects behaviour before this PR as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The code looks much more concise and cleaner now.
Yes, this is a limitation of the |
Relevant issue: #429
This PR adds the ability to resize windows with super + right-click, based on the quadrant that the mouse is in at the time of the initial click.
This modifies the behaviour of the super + click to move window feature to only work with left clicks, as that previously worked with any sort of click, including middle or right clicks (which is probably not the intended behaviour).