Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize window with Super + Right-Click Drag #664

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

Koranir
Copy link
Contributor

@Koranir Koranir commented Jul 30, 2024

Relevant issue: #429

This PR adds the ability to resize windows with super + right-click, based on the quadrant that the mouse is in at the time of the initial click.

This modifies the behaviour of the super + click to move window feature to only work with left clicks, as that previously worked with any sort of click, including middle or right clicks (which is probably not the intended behaviour).

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! Looks pretty good apart from some minor nitpicks.

@Quackdoc
Copy link
Contributor

If a app window has another window above it, you cannot do a horizontal drag in the top quandrants, likewise if there is a window below it, a bottom quadrant drag does not work.

if you have applications surrounding an app on all sides, horizontal adjustment seems impossible.

@Koranir
Copy link
Contributor Author

Koranir commented Aug 1, 2024

If a app window has another window above it, you cannot do a horizontal drag in the top quandrants, likewise if there is a window below it, a bottom quadrant drag does not work.

if you have applications surrounding an app on all sides, horizontal adjustment seems impossible.

Is this in the tiling mode? I'm not sure how to reproduce this.

On a maybe-related note, it looks like dragging tiling windows only works on one axis at a time (this also applies to dragging directly with the cursor on the corner).

@Quackdoc
Copy link
Contributor

Quackdoc commented Aug 1, 2024

Correct, it is in tiling mode, also can verify the exact same behavior when clicking the corner, it only effecting vertical resizing.

@Koranir
Copy link
Contributor Author

Koranir commented Aug 1, 2024

Yep, I can confirm now. That is a separate issue, which affects behaviour before this PR as well.

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The code looks much more concise and cleaner now.

@Drakulix
Copy link
Member

Drakulix commented Aug 1, 2024

Yep, I can confirm now. That is a separate issue, which affects behaviour before this PR as well.

Yes, this is a limitation of the ResizeForkGrab, which really needs to track two nodes to be able to handle corner resizing correctly. I don't think that is a deal-breaker for merging this though.

@Drakulix Drakulix merged commit e01a55a into pop-os:master Aug 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants