Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of non-atomic global in signal handler #42

Closed
jackpot51 opened this issue Oct 17, 2019 · 0 comments
Closed

Remove use of non-atomic global in signal handler #42

jackpot51 opened this issue Oct 17, 2019 · 0 comments

Comments

@jackpot51
Copy link
Member

You should not use global variables in signal handlers. If the logger is locked when the signal occurs, this could cause a deadlock. The atomic on the next line is okay because it has known ordering.

Originally posted by @jackpot51 in #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant