Systemd Offline Upgrade Support #34
Conversation
mmstick
force-pushed
the
upgrade
branch
4 times, most recently
from
15c1e09
to
f9f66a7
Compare
mmstick
force-pushed
the
upgrade
branch
5 times, most recently
from
52aab1c
to
7906eb7
Compare
|
As soon as the most recent commit builds, this is ready for testing of both the CLI and GTK frontend. |
mmstick
force-pushed
the
upgrade
branch
12 times, most recently
from
e1bf5e1
to
c979bb2
Compare
|
mmstick
force-pushed
the
upgrade
branch
3 times, most recently
from
d8a754b
to
ba7576a
Compare
|
Ideally we should also merge pop-os/desktop#37 to increase the success rate of an upgrade with this, to guarantee that |
mmstick
force-pushed
the
upgrade
branch
4 times, most recently
from
90a6787
to
b8d056c
Compare
Some debian packages are in the process of becoming transitional packages for snaps. This causes offline upgrades to fail when a transitonal debian package tries to use snapd to fetch and install a snap version of the package on upgrade. To solve this problem, we will be marking packages which have a pre-depends on snapd as held packages. This will prevent these packages from being upgraded during the offline upgrade.
It runs as a silent background service, which we should kill to prevent it from trying take control over dpkg, and to display notifications.
Setting KillMode=none on the init service will prevent systemd from SIGTERM'ing the upgrade script. Some extra dependencies and orderings were also defined for the services.
mmstick
force-pushed
the
upgrade
branch
3 times, most recently
from
a4e1be8
to
c20a0ee
Compare
The acpid service is masked during the upgrade so that the package can successfully upgrade. The /pop-upgrade files are now removed from the start, to prevent apt sources from being reverted. The sync command is used at the end to wait for any outputs to be flushed.
|
It looks like pop-upgrades from 19.04 to 19.10 do not work unless the system is first fully updated with darp5-1904-to-1910-journalctl.txt |
|
Does the source file exist? |
Vim upgrades should no longer prompt for an answer
| @@ -1,8 +1,13 @@ | |||
| #!/bin/sh | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
There are loads of unquoted variables here. I think this can be taken care of post-merge
| _ => unreachable!(), | ||
| }; | ||
|
|
||
| warn!("caught {} signal", signal); |
There was a problem hiding this comment.
You should not use global variables in signal handlers. If the logger is locked when the signal occurs, this could cause a deadlock. The atomic on the next line is okay because it has known ordering.
No description provided.