Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguous error on startup #944

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix ambiguous error on startup #944

wants to merge 2 commits into from
+11 −3

Conversation

alexgleason
Copy link

@alexgleason alexgleason commented Sep 16, 2024 •
edited
Loading

Fixes #923

Before & after:

Screenshot from 2024-09-15 18-58-17

patrickReiis
patrickReiis approved these changes Sep 16, 2024
View reviewed changes
Copy link

@patrickReiis patrickReiis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this message, accident

@martinwepner-otto
Copy link

Would be nice if this could be merged and released soon. In my team multiple developers ran into this when trying to connect with wrong credentials and the "cannot read property "replace" of undefined" was not very helpful.

@fin-dogedev
Copy link

This runtime type error causes the application to terminate if the connection to the database fails unexpectedly. As a result, the reconnection mechanism cannot take effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickReiis patrickReiis patrickReiis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'replace')
4 participants
@alexgleason @martinwepner-otto @fin-dogedev @patrickReiis