Gracefully handle empty snippets #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If snippet in Terraform code is optional, for example when ternary operator is used, then provider is not able to handle at the moment and crashes, trying to cast 'nil' interface into string. This commit changes the logic to prevent that and makes that only non 'nil' snippets will be used. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If snippet in Terraform code is optional, for example when ternary
operator is used, then provider is not able to handle at the moment and
crashes, trying to cast 'nil' interface into string.
This commit changes the logic to prevent that and makes that only non
'nil' snippets will be used.
Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io