Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes poshbotio/PoshBot#131 #132

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Conversation

DWOF
Copy link
Contributor

@DWOF DWOF commented Nov 3, 2018

Added a fix for issue #131

Description

Added a single line that wipes out the default channel rule when adding others

Related Issue

#131

Motivation and Context

Able to restrict commands in slack channels

How Has This Been Tested?

Confirmed that when adding rules the created configuration did not include the default channel rule.
Added rules and tested in own slack workspace.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@devblackops devblackops self-assigned this Nov 7, 2018
@devblackops devblackops added the bug label Nov 7, 2018
@devblackops
Copy link
Member

Good catch @DWOF. Thanks!

@devblackops devblackops merged commit 099941c into poshbotio:master Nov 7, 2018
@DWOF DWOF deleted the DAH_Contribution branch November 7, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants