Change from setup.cfg to pyproject.toml #73
Conversation
pyproject.toml
Outdated
| [tool.setuptools] | ||
| packages = ["htmltools"] | ||
| include-package-data = true | ||
| # test-suite = "tests" |
There was a problem hiding this comment.
This wasn't commented out in the old setup.cfg, but it caused errors in this file. Should it just be removed?
There was a problem hiding this comment.
I would set any test options using a pytest section
There was a problem hiding this comment.
Thanks, pytest seems to work without this line, so I'll just remove it.
pyproject.toml
Outdated
| [tool.setuptools] | ||
| packages = ["htmltools"] | ||
| include-package-data = true | ||
| # test-suite = "tests" |
There was a problem hiding this comment.
I would set any test options using a pytest section
| "setuptools", | ||
| "wheel" | ||
| ] | ||
| build-backend = "setuptools.build_meta" |
There was a problem hiding this comment.
If you use setuptools-scm, you can set the version automatically using git tags
(but the current approach seems totally fine and reasonable!)
There was a problem hiding this comment.
Thanks - maybe in the future we'll switch over.
|
One unfortunate thing about this change is that it apparently breaks pyright support when this py-htmltools is installed as an editable package with microsoft/pyright#3846 It looks like the workaround is to install with |
This PR switches htmltools from setup.cfg/setup.py to the newer pyproject.toml config file.