Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove make_source_manifest in favor of Manifest class #477

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

remove make_source_manifest in favor of Manifest class #477

wants to merge 4 commits into from

Conversation

mslynch
Copy link
Contributor

@mslynch mslynch commented Sep 8, 2023 •
edited
Loading

I noticed there was a lot of code shared between Manifest and make_source_manifest. These changes are going to be useful for an upcoming PR for some Posit Cloud changes.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4256 2754 65% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/actions.py 33% 🟢
rsconnect/api.py 68% 🟢
rsconnect/bundle.py 80% 🟢
rsconnect/main.py 55% 🟢
TOTAL 59% 🟢

updated for commit: 0aab0b3 by action🐍

@mslynch mslynch marked this pull request as ready for review September 8, 2023 20:14
mmarchetti
mmarchetti approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@mmarchetti mmarchetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We will need to do some QA on this before merging; probably best to do that after we finish the current release that is in beta.

@mslynch mslynch mentioned this pull request Sep 11, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmarchetti mmarchetti mmarchetti approved these changes

@omar-rs omar-rs omar-rs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mslynch @mmarchetti @omar-rs