More type fixes #590
More type fixes #590
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
| @@ -1347,7 +1347,7 @@ def _tweak_response(self, response: HTTPResponse) -> JsonData | HTTPResponse: | |||
| def get_extra_headers(self, url: str, method: str, body: str | bytes): | |||
| canonical_request_method = method.upper() | |||
| canonical_request_path = parse.urlparse(url).path | |||
| canonical_request_date = datetime.datetime.utcnow().strftime("%a, %d %b %Y %H:%M:%S GMT") | |||
| canonical_request_date = datetime.datetime.now(datetime.timezone.utc).strftime("%a, %d %b %Y %H:%M:%S GMT") | |||
There was a problem hiding this comment.
Note that this change will not result in changed output, because strftime() is being called with a format string.
| @@ -169,7 +169,10 @@ def pip_freeze(): | |||
| pip_stdout = filter_pip_freeze_output(pip_stdout) | |||
|
|
|||
| pip_stdout = ( | |||
| "# requirements.txt generated by rsconnect-python on " + str(datetime.datetime.utcnow()) + "\n" + pip_stdout | |||
| "# requirements.txt generated by rsconnect-python on " | |||
| + str(datetime.datetime.now(datetime.timezone.utc)) | |||
There was a problem hiding this comment.
This will result in +00:00 being added to the output.
| @@ -721,7 +731,7 @@ def update_content_item_last_build_time(self, guid: str, defer_save: bool = Fals | |||
| """ | |||
| with self._lock: | |||
| content = self.get_content_item(guid) | |||
| content["rsconnect_last_build_time"] = datetime.utcnow().strftime("%Y-%m-%dT%H:%M:%SZ") | |||
| content["rsconnect_last_build_time"] = datetime.now(timezone.utc).strftime("%Y-%m-%dT%H:%M:%SZ") | |||
There was a problem hiding this comment.
Note that this change will not result in changed output, because strftime() is being called with a format string.
| @@ -16,6 +16,7 @@ | |||
| import typing | |||
| import webbrowser | |||
| from os.path import abspath, dirname | |||
| from ssl import SSLError | |||
There was a problem hiding this comment.
ssl.SSLError is the same object as _ssl.SSLError.
See:
https://github.com/python/cpython/blob/v3.8.0/Lib/ssl.py#L102-L105
https://github.com/python/cpython/blob/v3.12.3/Lib/ssl.py#L104-L107See
|
The GitHub Actions workflows don't seem to be running on the latest commit. Any idea why? (It won't let me merge until they run.) |
It's because I renamed the default branch to |
|
Ironically, the workflow is called |
|
Ah thanks, I can fix it here. |
This PR makes more typing fixes.
NOTE: This PR also removes use of the deprecated function
datetime.datetime.utcnow(). This will result in a behavior change in logging in one place, where instead of writing2024-05-13 17:03:09.857000, it will write2024-05-13 17:03:09.857000+00:00. If this is undesirable, I can get it to format the string without the+00:00.