-
Notifications
You must be signed in to change notification settings - Fork 25
revise CLI documentation #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! The CLI documentation is 💯.
Left a few minor comments, but neither are blocking.
- opened | ||
- reopened | ||
- synchronize | ||
- closed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the target use case for running on closed? You might be able to remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the action docs I think the close event is used to delete the preview--the build is skipped on line 26 if the event is closed.
Co-authored-by: Taylor Steinberg <taylor@steinberg.xyz>
Intent
Add more comprehensive documentation of the CLI
Type of Change
Approach
docs/
mkdocs-click
to generate pages for eachrsconnect
subcommand.quartodoc
does not currently provide support for documenting command-line interfaces.rsconnect
command; this is a limitation of mkdocs-clickAutomated Tests
Added a preview action to deploy the site to github pages
Directions for Reviewers
Checklist