Skip to content

revise CLI documentation #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 22, 2025
Merged

revise CLI documentation #664

merged 8 commits into from
May 22, 2025

Conversation

edavidaja
Copy link
Collaborator

@edavidaja edavidaja commented May 2, 2025

Intent

Add more comprehensive documentation of the CLI

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

  • move the README that currently provides most documentation to docs/
    • The readme is currently disjointed and pretty long; this PR splits it into some thematically consistent chunks
    • replace the existing readme with a stripped down version and links to the new docs
  • Use mkdocs-click to generate pages for each rsconnect subcommand.
    • quartodoc does not currently provide support for documenting command-line interfaces.
    • we could render all the commands and subcommands as one page, but that seems less helpful than breaking things up by command

Automated Tests

Added a preview action to deploy the site to github pages

Directions for Reviewers

uv venv
uv pip install -e ".[docs]"
. ./.venv/bin/activate
mkdocs serve

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

Copy link

github-actions bot commented May 2, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5096 3828 75% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 3d990d1 by action🐍

Copy link

github-actions bot commented May 2, 2025

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-05-22 13:24 UTC

@edavidaja edavidaja marked this pull request as ready for review May 21, 2025 01:13
@edavidaja edavidaja changed the title add comprehensive CLI documentation revise CLI documentation May 21, 2025
@edavidaja edavidaja requested a review from a team May 21, 2025 01:15
Copy link
Collaborator

@tdstein tdstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! The CLI documentation is 💯.

Left a few minor comments, but neither are blocking.

- opened
- reopened
- synchronize
- closed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the target use case for running on closed? You might be able to remove this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the action docs I think the close event is used to delete the preview--the build is skipped on line 26 if the event is closed.

Co-authored-by: Taylor Steinberg <taylor@steinberg.xyz>
@edavidaja edavidaja merged commit cb014e8 into main May 22, 2025
12 of 14 checks passed
@edavidaja edavidaja deleted the mkdocs-click branch May 22, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants