This repository was archived by the owner on Aug 16, 2021. It is now read-only.
WIP: Use ebs volume with backup #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolayS
reviewed
Sep 23, 2018
There was a problem hiding this comment.
Awesome work!
Please see comments and text corrections.
Also, I'm a bit concerned that we don't have any error checks after "attach", "extract", and "detach" steps – if some steps fails, are we sure that the process will be interrupted and everything will be cleaned up? Maybe it's worth to have explicit checks for each step.
| # None | ||
| ####################################### | ||
| function dettach_db_ebs_drive() { | ||
| docker_exec bash -c "umount /backup" |
There was a problem hiding this comment.
what if this fails? (it can – if we still use it, for example)
There was a problem hiding this comment.
Диск останется подключенным, как это лучше обработать пока нет идей.
Closed
postgres-ai
reviewed
Sep 25, 2018
nancy_run.sh
Outdated
| apply_sql_before_db_restore | ||
| restore_dump | ||
| if [[ -z ${DB_EBS_VOLUME_ID+x} ]]; then | ||
| restore_dump; |
postgres-ai
reviewed
Sep 25, 2018
nancy_run.sh
Outdated
| msg " docker-machine ssh $DOCKER_MACHINE" | ||
|
|
||
| if [[ "$RUN_ON" == "aws" ]] && [[ ! -z ${DB_EBS_VOLUME_ID+x} ]]; then | ||
| attach_db_ebs_drive; |
postgres-ai
reviewed
Sep 25, 2018
nancy_run.sh
Outdated
| msg "Extract database backup from EBS volume" | ||
| docker_exec bash -c "rm -rf /var/lib/postgresql/9.6/main/*" | ||
|
|
||
| local op_start_time=$(date +%s); |
postgres-ai
reviewed
Sep 25, 2018
nancy_run.sh
Outdated
| result=$(docker_exec bash -c "([[ -f /backup/pg_wal.tar ]] \ | ||
| && tar -C /storage/postgresql/$PG_VERSION/main/pg_wal -xvf /backup/pg_wal.tar) || true") | ||
|
|
||
| local end_time=$(date +%s); |
postgres-ai
reviewed
Sep 25, 2018
| } | ||
|
|
||
| if [[ ! -z ${DB_EBS_VOLUME_ID+x} ]] && [[ ! "$DB_NAME" == "test" ]]; then | ||
| docker_exec bash -c "psql --set ON_ERROR_STOP=on -U postgres -c 'drop database if exists test;'" |
There was a problem hiding this comment.
let's just remove this step?
if it exists and $DB_NAME = test, the following line (rename) will just do nothing and we'll proceed.
postgres-ai
approved these changes
Sep 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.