This repository was archived by the owner on Aug 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
Option "--run-on ...", use public docker image; full CI tests; more #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UDPATE: Добавил пару пунктов в описание |
dmius
approved these changes
Jun 26, 2018
NikolayS
pushed a commit
that referenced
this pull request
Sep 18, 2018
Option "--run-on ...", use public docker image; full CI tests; more
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Большой PR, в котором:
--run-on
— определяет, где будет запускаться, локально (docker run ...
) или докер-машина в AWS EC2--aws-***
адаптированы к--run-on aws
--run-on aws
--run-on localhost
реализован и является вариантом по умолчанию--run-on localhost
(временно отключены).gitignore
--run-on localhost
вместо копирования файлов (особенно касается больших файлов типа дампа БД) используются хардлинки. Может не работать, если на компьютере несколько разделов (см TODO)./docker
объявлена DEPRECATEDTODO (скорее всего уже не в этом PR):
/tests/nancy_run_localhost***
--run-on aws
, то ругаться сразу же, если вдруг задана какая-либо опция--aws-***
--run-on localhost
[[ .. ]]
или[ .. ]
-- выбрать что-то одно, скорее второе; и тд)