This repository was archived by the owner on Aug 16, 2021. It is now read-only.
"Full" / local tests in CirlceCI + a lot of improvements #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolayS
changed the title
dmius
approved these changes
Jun 29, 2018
nancy_run.sh
Outdated
|
|
||
| [ ! -z ${WORKLOAD_BASIS_PATH+x} ] && ! checkPath WORKLOAD_BASIS_PATH && >&2 echo "WARNING: file $WORKLOAD_BASIS_PATH given by workload_basis_path not found" | ||
| echo "WORKLOAD_FULL_PATH: $WORKLOAD_FULL_PATH" |
There was a problem hiding this comment.
ага, но это твоё, я лишь сократил текст
nancy_run.sh
Outdated
| if [ ! -z ${WORKLOAD_CUSTOM_SQL+x} ]; then | ||
| checkPath WORKLOAD_CUSTOM_SQL | ||
| if [ "$?" -ne "0" ]; then | ||
| #>&2 echo "WARNING: Value given as workload-custom-sql: '$WORKLOAD_CUSTOM_SQL' not found as file will use as content" |
There was a problem hiding this comment.
Это выводить для отлдки не помешает наверно, то есть при наличии --debug, но это на будущее
NikolayS
added a commit
that referenced
this pull request
Sep 18, 2018
"Full" / local tests in CirlceCI + a lot of improvements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Чтобы запускать тесты на CircleCI, мы поручаем CircleCI запускать наш nancy-контейнер, а
nancy_run.shпередаём его ID (хэш)Тесты почти заработали, осталась проблема проброса файлов в контейнер.
Попутно переформатирован код и сделано много небольших правок.
+ README.md с базовой информацией.