This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Dmius nancy cli #28
Merged
Dmius nancy cli #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 27, 2018 12:55
NikolayS
reviewed
Jun 27, 2018
nancy.sh
Outdated
| cmd="" | ||
|
|
||
| case "$1" in | ||
| run ) |
There was a problem hiding this comment.
Интересно, может сделать полную динамику и всегда искать nancy_слово.sh а если нет такого, ругаться?
NikolayS
reviewed
Jun 27, 2018
nancy.sh
Outdated
| ;; | ||
| esac | ||
|
|
||
| while [ -n "$1" ] |
There was a problem hiding this comment.
Хм, и этот цикл сделает проброс остатка всех параметров?
И при этом скажем, nancy_run.sh вызовется только 1 раз?
Как-то вызов в цикле удивляет
There was a problem hiding this comment.
А, всё, понял, вязов ниже, после цикла
|
Над тестами подумаю... |
NikolayS
approved these changes
Jun 28, 2018
|
Стоит ещё простой тест написать, что |
|
Увидел тесты :) Поправляю |
added 2 commits
June 28, 2018 19:00
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.