-
Notifications
You must be signed in to change notification settings - Fork 7
Dmius nancy cli #28
Dmius nancy cli #28
Conversation
nancy.sh
Outdated
cmd="" | ||
|
||
case "$1" in | ||
run ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Интересно, может сделать полную динамику и всегда искать nancy_слово.sh а если нет такого, ругаться?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
думаю можно
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Дим, а тесты?
nancy.sh
Outdated
;; | ||
esac | ||
|
||
while [ -n "$1" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Хм, и этот цикл сделает проброс остатка всех параметров?
И при этом скажем, nancy_run.sh вызовется только 1 раз?
Как-то вызов в цикле удивляет
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А, всё, понял, вязов ниже, после цикла
Над тестами подумаю... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Всё ок, только были табы вместо пробелов, поправил своим коммитом
- переименовал nancy.sh в nancy
Стоит ещё простой тест написать, что |
Увидел тесты :) Поправляю |
No description provided.