This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Use containerHash in paths #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolayS
reviewed
Jun 28, 2018
| else | ||
| if [ "$RUN_ON" = "localhost" ]; then | ||
| ln $1 "$TMP_PATH/pg_nancy_home_${CURRENT_TS}/" # TODO: option – hard links OR regular `cp` | ||
| ln $1 "$TMP_PATH/pg_nancy_home_${CURRENT_TS}/$containerHash/" # TODO: option – hard links OR regular `cp` |
There was a problem hiding this comment.
а вот тут CURRENT_TS же остаётся, т.е. опять непонятно будет, куда файлы складывать
There was a problem hiding this comment.
На этот каталог у нас монтируется докер стр 531
containerHash=$(docker run --name="pg_nancy_${CURRENT_TS}" \
-v $TMP_PATH/pg_nancy_home_${CURRENT_TS}:/machine_home \
-dit "postgresmen/postgres-with-stuff:pg${PG_VERSION}" \
оставить $TMP_PATH/pg_nancy_home:/machine_home ?
There was a problem hiding this comment.
а серверные конфиги тогда не будут общими?
There was a problem hiding this comment.
смотри, снаружи я знаю ID контейнера, но не знаю CURRENT_TS
поэтому идея была монтировать сам $TMP_PATH как есть, для всех, а там уже работат ьв поддиректориях, чтобы не пересекаться
в такой схеме есть возможность и общие файлы использовать — то, что в самом $TMP_PATH
NikolayS
approved these changes
Jun 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.