Skip to content
This repository was archived by the owner on Aug 16, 2021. It is now read-only.

fix cleanup steps #55

Merged
merged 3 commits into from
Jul 10, 2018
Merged

fix cleanup steps #55

merged 3 commits into from
Jul 10, 2018

Conversation

NikolayS
Copy link
Collaborator

@NikolayS NikolayS commented Jul 10, 2018 •
edited
Loading

In $TMP_PATH directory (mapped to /machine_home in the container), the container creates a subdirectory nancy_*****. In the end, we need to delete it (cleanupAndExit function).

The problem is that it cannot be removed without using sudo so we get an error:

rm: cannot remove ‘/tmp/nancy_9326749f1ee7df0d176646395fdc9786dbf67883d55217f9e28f301a97da8954’: Operation not permitted

This PR resolves this: instead of direct rm -rf we use docker exec ... call.

@NikolayS NikolayS requested a review from dmius July 10, 2018 01:35
@dmius dmius merged commit e39684a into master Jul 10, 2018
@NikolayS NikolayS deleted the fix_cleanup branch July 10, 2018 20:01
NikolayS pushed a commit that referenced this pull request Sep 18, 2018
@dmius
Merge pull request #55 from startupturbo/fix_cleanup
841e5ee 
fix cleanup steps
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@dmius dmius dmius approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dmius dmius

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikolayS @dmius