This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Use pg-restore to restore directory one file dump #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolayS
reviewed
Jul 27, 2018
| checkPath AFTER_DOCKER_INIT_CODE | ||
| if [ "$?" -ne "0" ]; then | ||
| #>&2 echo "WARNING: Value given as after_db_init_code: '$AFTER_DOCKER_INIT_CODE' not found as file will use as content" | ||
| echo "$AFTER_DOCKER_INIT_CODE" > $TMP_PATH/after_docker_init_code_tmp.sh |
There was a problem hiding this comment.
Можно было бы проще, без записи в файл — eval
NikolayS
reviewed
Jul 27, 2018
| echo "$AFTER_DOCKER_INIT_CODE" > $TMP_PATH/after_docker_init_code_tmp.sh | ||
| AFTER_DOCKER_INIT_CODE="$TMP_PATH/after_docker_init_code_tmp.sh" | ||
| else | ||
| [ "$DEBUG" -eq "1" ] && echo "DEBUG: Value given as commands-after-docker-init will use as filename" |
There was a problem hiding this comment.
Можешь обьяснить смысл сообщения? Не уверен, что правильно понял, зачем оно
There was a problem hiding this comment.
Сообщение выводится только если включен режим отладки.
NikolayS
reviewed
Jul 27, 2018
| @@ -641,6 +655,7 @@ function cleanupAndExit { | |||
| echo "$(date "+%Y-%m-%d %H:%M:%S"): Remove temp files..." # if exists | |||
| docker $dockerConfig exec -i ${containerHash} sh -c "sudo rm -rf $MACHINE_HOME" | |||
| rm -f "$TMP_PATH/after_db_init_code_tmp.sql" | |||
| rm -f "$TMP_PATH/after_docker_init_code_tmp.sh" | |||
There was a problem hiding this comment.
Я думаю, что раз мы там плодим файлы, лучше удалять всю поддиректорию, только убедиться что имя уникальное
NikolayS
reviewed
Jul 27, 2018
| docker_exec bash -c "chmod +x $MACHINE_HOME/$AFTER_DOCKER_INIT_CODE_FILENAME" | ||
| docker_exec sh $MACHINE_HOME/$AFTER_DOCKER_INIT_CODE_FILENAME | ||
| END_TIME=$(date +%s); | ||
| DURATION=$(echo $((END_TIME-OP_START_TIME)) | awk '{printf "%d:%02d:%02d", $1/3600, ($1/60)%60, $1%60}') |
There was a problem hiding this comment.
Заглавными буквами предполагалось именовать глобальные константы. А тут обычная переменная.
NikolayS
reviewed
Jul 27, 2018
| @@ -854,6 +882,8 @@ then | |||
| fi | |||
| OP_START_TIME=$(date +%s); | |||
| echo "$(date "+%Y-%m-%d %H:%M:%S"): Restore database dump" | |||
| #CPU_CNT=$(cat /proc/cpuinfo | grep processor | wc -l) | |||
| CPU_CNT=$(docker_exec bash -c "cat /proc/cpuinfo | grep processor | wc -l") # for execute in docker | |||
There was a problem hiding this comment.
Да уж, это было совсем неправильно раньше :)
NikolayS
approved these changes
Jul 27, 2018
NikolayS
reviewed
Jul 28, 2018
| @@ -755,6 +764,8 @@ elif [[ "$RUN_ON" = "aws" ]]; then | |||
| exit 1; | |||
| fi | |||
| echo "$(date "+%Y-%m-%d %H:%M:%S"): Docker $DOCKER_MACHINE is running." | |||
| echo " To connect docker machine use:" | |||
NikolayS
approved these changes
Jul 28, 2018
NikolayS
added a commit
that referenced
this pull request
Sep 18, 2018
Use pg-restore to restore directory one file dump
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.