add support for the old naming libs convention on windows (ssleay32.lib and libeay32.lib) #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ib and libeay32.lib) According to the postgresql-17 requirements https://www.postgresql.org/docs/17/install-requirements.html the minimum required version of openssl is 1.0.2. In that version, the naming convention on windows is still ssleay32.[lib|dll] and libeay32.[lib|dll] instead of libssl.[lib|dll] and libcrypto.[lib|dll]. It changed in version 1.1.0 openssl/openssl#10332 (comment) Thus there is a bug in meson.build as it only supports libssl.lib and libcrypto.lib, hence a simple patch that fixes the issue and supports both conventions.
…ib and libeay32.lib) According to the postgresql-17 requirements https://www.postgresql.org/docs/17/install-requirements.html the minimum required version of openssl is 1.0.2. In that version, the naming convention on windows is still ssleay32.[lib|dll] and libeay32.[lib|dll] instead of libssl.[lib|dll] and libcrypto.[lib|dll]. It changed in version 1.1.0 openssl/openssl#10332 (comment) Thus there is a bug in meson.build as it only supports libssl.lib and libcrypto.lib, hence a simple patch that fixes the issue and supports both conventions.
…ib and libeay32.lib) According to the postgresql-17 requirements https://www.postgresql.org/docs/17/install-requirements.html the minimum required version of openssl is 1.0.2. In that version, the naming convention on windows is still ssleay32.[lib|dll] and libeay32.[lib|dll] instead of libssl.[lib|dll] and libcrypto.[lib|dll]. It changed in version 1.1.0 openssl/openssl#10332 (comment) Thus there is a bug in meson.build as it only supports libssl.lib and libcrypto.lib, hence a simple patch that fixes the issue and supports both conventions.
…ib and libeay32.lib) fixes according to comments from https://www.postgresql.org/message-id/CAN55FZ1Nk8wqY%3DmTrN78H026TuGV50h2H6uq1PwxhTauPYi3ug%40mail.gmail.com
|
Thanks for your Pull Request! 😄 This repo on GitHub is just a mirror of our real git repositories though, and can't really handle PRs. 😦 Hopefully you can redo the PR, and direct it to the git.postgresql.org repos? We have a developer guide, if that helps: https://wiki.postgresql.org/wiki/So,_you_want_to_be_a_developer%3F. |
dutow
pushed a commit
to dutow/postgres
that referenced
this pull request
Jan 7, 2025
postgres#197) * TDE TupleTableSlot for storing decrypted tuple along with the buffer tuple Tuple data in the shared buffer is encrypted. To store the tuple in the tupleTableslot, the tuple data is decrypted into allocated memory. This memory needs to be properly cleaned up. However, with the existing BufferHeapTupleTableSlot, there is no way to free this memory until the end of the current query executor cycle. To address this, the commit introduces TDEBufferHeapTupleTableSlot, a clone of BufferHeapTupleTableSlot that keeps a reference to the allocated decrypted tuple and frees it when the tuple slot is cleared. Most of the code is borrowed from the BufferHeapTupleTableSlot implementation, ensuring that TDEBufferHeapTupleTableSlot can be cast to BufferHeapTupleTableSlot Apart from the above, a workaround to clear the decrypted tuple pointer is added to the TDEBufferHeapTupleTableSlot for cases when the slot is reused while the previously decrypted tuple was cleared out by MemoryContext deletion, instead of through the slot cleanup callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the postgresql-17 requirements https://www.postgresql.org/docs/17/install-requirements.html
the minimum required version of openssl is 1.0.2.
In that version, the naming convention on windows is still ssleay32.[lib|dll] and
libeay32.[lib|dll] instead of libssl.[lib|dll] and libcrypto.[lib|dll].
It changed in version 1.1.0 openssl/openssl#10332 (comment)
Thus there is a bug in meson.build as it only supports libssl.lib and libcrypto.lib,
hence a simple patch that fixes the issue and supports both conventions.