Skip to content

Add test for config Serializer #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2022
Merged

Add test for config Serializer #102

merged 4 commits into from
Jul 30, 2022

Conversation

drdrsh
Copy link
Collaborator

@drdrsh drdrsh commented Jul 30, 2022

Follow up to #101 to add test for serialization.
I verified that the test fails if nested fields come before simple fields

thread 'config::test::test_serialize_configs' panicked at 'called `Result::unwrap()` on an `Err` value: ValueAfterTable', src/config.rs:566:53

@drdrsh drdrsh changed the title Add test for serializer Add test for config Serializer Jul 30, 2022
@levkk levkk merged commit 35381ba into postgresml:main Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@levkk levkk levkk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drdrsh @levkk