Skip to content

Main Thread Panic when swarmed with clients #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 5, 2022
Merged

Main Thread Panic when swarmed with clients #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d512e1d
Main Thread Panic when swarmed with clients
drdrsh Sep 5, 2022
62e486b
fix
drdrsh Sep 5, 2022
1de08e0
fix
drdrsh Sep 5, 2022
9fbdd61
1024
drdrsh Sep 5, 2022
75c9cff
fix
drdrsh Sep 5, 2022
fd69c0b
remove test
drdrsh Sep 5, 2022
01f2d45
Update src/client.rs
levkk Sep 5, 2022
1ed38cd
Update src/main.rs
levkk Sep 5, 2022
a1d2fbf
Update src/client.rs
levkk Sep 5, 2022
1a272dc
Update src/main.rs
levkk Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ pub async fn client_entrypoint(
mut stream: TcpStream,
client_server_map: ClientServerMap,
shutdown: Receiver<()>,
drain: Sender<i8>,
drain: Sender<i32>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, I forgot we're keeping this one alive until the client disconnects. Good catch. I'd make it a usize to avoid this problem forever.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought....we're only sending 1 and 0 through this channel. Why would it overflow?

Copy link
Contributor

@levkk levkk Sep 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, because total_clients becomes an i8. Wow! Subtle.

admin_only: bool,
) -> Result<(), Error> {
// Figure out if the client wants TLS or not.
Expand Down
2 changes: 1 addition & 1 deletion src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ async fn main() {
let mut interrupt_signal = unix_signal(SignalKind::interrupt()).unwrap();
let mut sighup_signal = unix_signal(SignalKind::hangup()).unwrap();
let (shutdown_tx, _) = broadcast::channel::<()>(1);
let (drain_tx, mut drain_rx) = mpsc::channel::<i8>(2048);
let (drain_tx, mut drain_rx) = mpsc::channel::<i32>(2048);
let (exit_tx, mut exit_rx) = mpsc::channel::<()>(1);

info!("Waiting for clients");
Expand Down