14 look a like #115
Merged
14 look a like #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 20, 2023 17:21
Rewrite test for look-a-like functional. Current tests contain correlation columns and queries have more nodes and description features. Add aqo_k as custom parameter to define few number of features for prediction. Its default value is 3. Queries can contain a larger number of features than 3 especially generic queries. Also add predict_a_few_neibours parameter for switch avalable to predict a few neibors than 3. It is done for not to change the previous logic of the code
…ke test, besides add two additional cases where look-a-like should not be applied.
Alena0704
force-pushed
the
14-look-a-like
branch
from
c6eae6d to
09f4d12
Compare
danolivo
reviewed
Jan 23, 2023
aqo.c
Outdated
| NULL | ||
| ); | ||
|
|
||
| DefineCustomIntVariable("aqo.k_neighbors_threshold", |
There was a problem hiding this comment.
Здесь те же вопросы, что и в #112
Ну и внимательнее смотреть в свои комменты, прогонять через проверку словаря, грамматики, может быть.
There was a problem hiding this comment.
Параметр переименовала и добавила более понятные описания в них.
Ответила на вопросы в #112
… for predicting and add more understandable explanations of guc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.