-
Notifications
You must be signed in to change notification settings - Fork 26
Pgpro13 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pgpro13 #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise it looks good to me, if everything compiles and works well with all supported version
@@ -0,0 +1,67 @@ | |||
Parsed test spec with 2 sessions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you, please, add info into review section of README (https://github.com/postgrespro/pg_query_state#tests) about Postgres/OS versions where we need this new variants of test outputs (corner_cases_3.out, corner_cases_4.out)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I updated README.md and added this information (in commit a586969).
…INTERRUPTS in the CheckAndHandleCustomSignals() function to prevent the posible deadlock while using the pg_query_state extension Authored by: Konstantin Knizhnik <knizhnik@garret.ru>
This PR seems to be outdated and should be replaced with a new PR from https://github.com/postgrespro/pg_query_state/tree/PGPRO13_installcheck, IIUC. @dlepikhova? |
The proposed patch allows testing this extension in installcheck mode.