Skip to content

Pgpro13 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Pgpro13 #19

wants to merge 12 commits into from

Conversation

dlepikhova
Copy link
Contributor

The proposed patch allows testing this extension in installcheck mode.

@dlepikhova dlepikhova requested a review from ololobus January 25, 2021 11:35
Copy link
Contributor

@ololobus ololobus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it looks good to me, if everything compiles and works well with all supported version

@@ -0,0 +1,67 @@
Parsed test spec with 2 sessions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you, please, add info into review section of README (https://github.com/postgrespro/pg_query_state#tests) about Postgres/OS versions where we need this new variants of test outputs (corner_cases_3.out, corner_cases_4.out)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I updated README.md and added this information (in commit a586969).

@ololobus
Copy link
Contributor

This PR seems to be outdated and should be replaced with a new PR from https://github.com/postgrespro/pg_query_state/tree/PGPRO13_installcheck, IIUC. @dlepikhova?

@ololobus ololobus closed this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants