Allow to feed smth into stdin of psql and safe_psql, enable node restart logging #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arssher
changed the title
|
Please fix the tests. |
node.restart() logging was previously broken: -l option was not supplied, so its stdout/err wasn't redirected -- this is option of pg_ctl, not of postgres itself, and pg_ctl didn't reused it. That was also the reason of 'write_to_pipe' existence: if pg_ctl restart's stdout was fed to pipe, communicate() hanged, reading stdout of postgres infinitely. Now we ride on 'start' routine for restart and get the same behaviour, including logging. 'inp' param of safe_psql and psql was renamed to input for consistency (we don't use here standard input() function quite often, right?), test for it was added.
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 95.17% 95.08% -0.09%
==========================================
Files 4 4
Lines 829 835 +6
==========================================
+ Hits 789 794 +5
- Misses 40 41 +1
Continue to review full report at Codecov.
|
|
Merged, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdinallows to test e.g. COPY FROM, see https://github.com/postgrespro/pg_shardman/commit/0f3866d6e7db820622480fa62a3abc5e748e965d#diff-9c0147891760ab4b5aea57c1d48e4ec0R311 for example