V0.3.0 #16
Merged
V0.3.0 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2017
mrmlnc
approved these changes
Nov 22, 2017
index.js
Outdated
| var directives = options.directives || defaultDirectives; | ||
|
|
||
| for (var i = 0; i < directives.length; i++) { | ||
| if (name.toLowerCase() === directives[i].name) { |
There was a problem hiding this comment.
Maybe it will be better?
var directive = directives[i];
results.push(directive.start + data + directive.end);| expect(parser('<!doctype html>')).to.eql(['<!doctype html>']); | ||
| }); | ||
|
|
||
| it('should be parse directive', function() { |
There was a problem hiding this comment.
IMHO, need some test case when <?php ...> nested into any html tag (for example, <div>).
There was a problem hiding this comment.
Very thanks, i find bug, and fixed him. )
There was a problem hiding this comment.
<?php wp_nav_menu(array('theme_location' => 'primary', 'menu_class' => 'header-nav-bar')); ?>
is not working correctly
There was a problem hiding this comment.
@IgorMotorny Hi, I need more information. Create a separate Issue and describe the problem case. Thanks.
|
@posthtml/collaborators LGTM ? |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.