Introduce Telemetry override for 'count' and 'sample_sum' #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsantero
previously approved these changes
Dec 5, 2017
added 2 commits
December 5, 2017 16:44
In some rare cases -- like in the prometheus sink -- it's necessary to fake the count and sample_sum of a telemetry. Say, if you're windowing a certain troublesome kind of aggregation. Well, that's what this commit does: it lets you fake those two things. I expect the tests are broken now. I'll work those tomorrow. This work via feedback from @dparton. Signed-off-by: Brian L. Troutwine <blt@postmates.com>
This commit catches our tests up to the changes made to Telemetry, in particular with regard to the overriding of sum and count for some kinds of Telemetry. Signed-off-by: Brian L. Troutwine <blt@postmates.com>
blt
force-pushed
the
keep_count_sum_alive_in_prom_sink
branch
from
45cc75d
to
7019c54
Compare
blt
pushed a commit
that referenced
this pull request
Dec 6, 2017
This release adjusts the Elasticsearch sink to better handle timeouts and clear its internal buffer. Also, we now keep a long-lived sum/count for Prometheus sink Summaries, even despite the windowing. * 859ca8a :: Avoid catastrophic failure when an ES request times out (#356) * 071328c :: Perform a linear search in ES buffer (#357) * 86f753c :: Introduce Telemetry override for 'count' and 'sample_sum' (#354) Signed-off-by: Brian L. Troutwine <blt@postmates.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases -- like in the prometheus sink -- it's necessary to fake the count and sample_sum of a telemetry. Say, if you're windowing a certain troublesome kind of aggregation. Well, that's what this commit does: it lets you fake those two things.