Perform a linear search in ES buffer #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't keep the internal ES buffer in sorted order. The binary search performed by UUID is inappropriate and will fail to find the item to remove from buffer. This is... bad for everyone. Signed-off-by: Brian L. Troutwine <blt@postmates.com>
blt
pushed a commit
that referenced
this pull request
Dec 6, 2017
This release adjusts the Elasticsearch sink to better handle timeouts and clear its internal buffer. Also, we now keep a long-lived sum/count for Prometheus sink Summaries, even despite the windowing. * 859ca8a :: Avoid catastrophic failure when an ES request times out (#356) * 071328c :: Perform a linear search in ES buffer (#357) * 86f753c :: Introduce Telemetry override for 'count' and 'sample_sum' (#354) Signed-off-by: Brian L. Troutwine <blt@postmates.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't keep the internal ES buffer in sorted order. The binary
search performed by UUID is inappropriate and will fail to find
the item to remove from buffer. This is... bad for everyone.
Signed-off-by: Brian L. Troutwine blt@postmates.com