Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python syntax preprocessor #97

Closed
wants to merge 1 commit into from
Closed

Conversation

icarito
Copy link

@icarito icarito commented Jan 26, 2018

No description provided.

@posva
Copy link
Owner

posva commented Jan 26, 2018

what for?

@adriaanzon
Copy link
Collaborator

Can you point to the documentation of the python preprocessor, so we can confirm it is needed to add support for py in addition to python?

@icarito
Copy link
Author

icarito commented Jan 26, 2018

Oh, sorry, sure! I use this with this loader:
https://github.com/icarito/python-webpack-loader

@icarito
Copy link
Author

icarito commented Jan 26, 2018

By the way, thanks for this awesome project.
I don't have a full understanding of all the moving parts, I'm using a high level framework called Nuxt.js.
However, I understand it's using vue-loader in the background to load python-webpack-loader (whose npm package is py-loader).
My script tag is thus <script lang="py?compiler=pj">.
I have to admit I didn't think the regexp through, I simply assumed it's meaning and adapted for my use.
Happy coding!

@icarito
Copy link
Author

icarito commented Feb 1, 2018

https://github.com/nuxt-community/python-module I've contributed a nuxt module to make it easier to write python vue components with zero boilerplate. :-)

@adriaanzon adriaanzon self-assigned this Feb 22, 2018
@adriaanzon
Copy link
Collaborator

adriaanzon commented Dec 2, 2018

I am going to hold off on this, since it is going to contribute to the slowness of this plugin (#95), without benefiting many people. I am planning on creating something that will "lazy load" languages, so only the languages used in the opened Vue file will be loaded. When that is ready, then we could think of adding this.

I think the idea stated here #109 (comment), would also be a good solution for this type of uncommonly embedded language. We could also move s:register_language() to the autoload folder so people can use it from their after/syntax/vue.vim, but I think I am more of a fan of the configuration variable approach mentioned at #109 (comment).

@adriaanzon adriaanzon closed this Dec 2, 2018
@adriaanzon adriaanzon mentioned this pull request Jan 5, 2019
@adriaanzon adriaanzon added the pending Waiting for a feature/bugfix before this can be implemented label Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Waiting for a feature/bugfix before this can be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants