779. K-th Symbol in Grammar #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokuhirat
reviewed
Aug 15, 2025
| int kthGrammar(int n, int k) { | ||
| if (k == 1) return 0; | ||
| int k_parity = k & 1; | ||
| if (k_parity == 0) k_parity = 2; |
There was a problem hiding this comment.
この行が読みやすさに寄与しているか微妙だなと思い、取り除いてk_parity が 0 か 1 で良い気がしました。
There was a problem hiding this comment.
そう思います。ちょっと1-indexedにとらわれすぎました。
tokuhirat
reviewed
Aug 15, 2025
| if (k_parity == 0) k_parity = 2; | ||
| int k_prev = k + 1 >> 1; | ||
| int prev = kthGrammar(n - 1, k_prev); | ||
| if (prev == 0 && k_parity == 1 || prev == 1 && k_parity == 2) { |
There was a problem hiding this comment.
k_parity == 2 の時には prev とは違う文字になるの方が伝わりやすいと思いました。
There was a problem hiding this comment.
反転するという捉え方が書いているときになかったのでこんな感じになってしまいました。
ただその捉え方をするなら結局while文などで書いたほうがいい気もしますね。
nodchip
reviewed
Aug 16, 2025
| if (k == 1) return 0; | ||
| int k_parity = k & 1; | ||
| if (k_parity == 0) k_parity = 2; | ||
| int k_prev = k + 1 >> 1; |
There was a problem hiding this comment.
+ と >> のどちらの優先度が高いか、分かりづらいように思いました。
int k_prev = (k + 1) >> 1;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/k-th-symbol-in-grammar/description/