Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] cleanup linux build process #93

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

lambdalemon
Copy link
Contributor

This might break the windows build?

appimagetool is not working, probably because appimage requires relative not absolute path and the qml files are specified in absolute path? Might be fixable with qrc?

Also has to disable the togglebox indicator because it's not working...

height: 38
x: (parent.width - width) / 2
y: (parent.height - height) / 2
source: "image://default/check/#ffffff"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These elements come from the initial parent project https://github.com/matzman666/OpenVR-InputEmulator
I have had to make a few adjustments with newer QT versions etc, but it mostly works on Windows pretty well, Linux seems to have a few more conflicts with some of the QT elements

Copy link
Owner

@pottedmeat7 pottedmeat7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, doesn't look like it should affect the windows install too much other than WatchdogProvider I forget if a certain service uses these paths during certain Driver DLL_EXPORT loading steps maybe..
https://github.com/pottedmeat7/OpenVR-WalkInPlace/pull/93/files#diff-5093893db60675e2938b3442c39149eb7176070aaea3ae5d64a430823ab415ddL22-L25

@lambdalemon
Copy link
Contributor Author

Could that be something leftover from a previous version of openvr sdk? I was referencing the newest driver tutorial https://github.com/ValveSoftware/openvr/blob/master/samples/drivers/drivers/tutorial/README.md and WatchdogProvider does not seem to be required.

Do I need to modify the .sln file to make sure everything still works on windows? Or would that belong to a different commit?

@pottedmeat7
Copy link
Owner

It could be old and not necessary by now. Yeah getting the SLN updated and windows running can be another following commit. I'll probably get to it soon and then I can create a newer installer also.

@pottedmeat7 pottedmeat7 merged commit 2a06985 into pottedmeat7:master Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants