Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to create new -postfixed.js bundles #8622

Merged

Conversation

alxndrsn
Copy link
Member

@alxndrsn alxndrsn commented Apr 12, 2023

Tested with existing -postfixed.js builds, the only differences are in pouchdb-1.1.0-postfixed.js, and all whitespace:

$ git diff
diff --git a/tests/integration/deps/pouchdb-1.1.0-postfixed.js b/tests/integration/deps/pouchdb-1.1.0-postfixed.js
index b832ce49..296bedb5 100644
--- a/tests/integration/deps/pouchdb-1.1.0-postfixed.js
+++ b/tests/integration/deps/pouchdb-1.1.0-postfixed.js
@@ -4068,7 +4068,7 @@ exports.MD5 = function (string) {
     return   wordToHexValue;
   }
 
-  //**  function Utf8Encode(string) removed. Aready defined in pidcrypt_utils.js
+  //** function Utf8Encode(string) removed. Aready defined in pidcrypt_utils.js
 
   var x = [];
   var k, AA, BB, CC, DD, a, b, c, d;
@@ -4077,7 +4077,7 @@ exports.MD5 = function (string) {
   var S31 = 4, S32 = 11, S33 = 16, S34 = 23;
   var S41 = 6, S42 = 10, S43 = 15, S44 = 21;
 
-  //  string = Utf8Encode(string); #function call removed
+  //   string = Utf8Encode(string); #function call removed
 
   x = convertToWordArray(string);
 
@@ -5889,4 +5889,4 @@ function pouchCollate(a, b) {
 };;
 },{}]},{},[12])
 (12)
-});
+});
\ No newline at end of file

@alxndrsn
Copy link
Member Author

Alternatively this could live in one of:

  • scripts/
  • bin/

@alxndrsn
Copy link
Member Author

alxndrsn commented May 5, 2023

@alxndrsn
Copy link
Member Author

alxndrsn commented May 5, 2023

I'd keep the script where it is, as anyone looking to extend the migration tests is likely to look in that directory and find it helpful. If it were in bin/, it might also need a more descriptive name, e.g. get-postfixed-pouchdb-build-for-integration-test-deps.sh...

Copy link
Member

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

One optional improvement...

@@ -0,0 +1,30 @@
#!/bin/bash -eu

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment about why the postfixed build is useful?

@alxndrsn alxndrsn force-pushed the add-script-get-postfixed-pouchdb-build branch from 91d0e68 to ddc2456 Compare May 9, 2023 04:35
@alxndrsn alxndrsn merged commit 8896707 into pouchdb:master May 9, 2023
@alxndrsn alxndrsn deleted the add-script-get-postfixed-pouchdb-build branch May 9, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants