Skip to content

chore(common): improve hasSynced #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2024
Merged

chore(common): improve hasSynced #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4986dd3
chore(common): improve has synced to use lastSynced
May 9, 2024
096e320
chore(common): improve has synced
May 9, 2024
3afa7ed
chore(common): improve has synced
May 9, 2024
1b76310
chore(common): improve has synced
May 9, 2024
8c7164e
chore(common): improve has synced
May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unlucky-hats-cover.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@powersync/common": patch
---

Fix hasSynced to change when there is no data on app load
9 changes: 6 additions & 3 deletions packages/common/src/client/AbstractPowerSyncDatabase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,10 @@ export abstract class AbstractPowerSyncDatabase extends BaseObserver<PowerSyncDB
this.syncStreamImplementation = this.generateSyncStreamImplementation(connector);
this.syncStatusListenerDisposer = this.syncStreamImplementation.registerListener({
statusChanged: (status) => {
this.currentStatus = new SyncStatus({ ...status.toJSON(), hasSynced: this.currentStatus?.hasSynced });
this.currentStatus = new SyncStatus({
...status.toJSON(),
hasSynced: this.currentStatus?.hasSynced || !!status.lastSyncedAt
});
this.iterateListeners((cb) => cb.statusChanged?.(this.currentStatus));
}
});
Expand Down Expand Up @@ -766,7 +769,7 @@ export abstract class AbstractPowerSyncDatabase extends BaseObserver<PowerSyncDB
`SELECT DISTINCT tbl_name FROM sqlite_master WHERE rootpage IN (SELECT json_each.value FROM json_each(?))`,
[JSON.stringify(rootPages)]
);
for (let table of tables) {
for (const table of tables) {
resolvedTables.push(table.tbl_name.replace(POWERSYNC_TABLE_MATCH, ''));
}
}
Expand Down Expand Up @@ -937,7 +940,7 @@ export abstract class AbstractPowerSyncDatabase extends BaseObserver<PowerSyncDB
? filteredTables
: filteredTables.map((t) => t.replace(POWERSYNC_TABLE_MATCH, ''));

for (let table of mappedTableNames) {
for (const table of mappedTableNames) {
changedTables.add(table);
}
}
Expand Down