[Fix] Flipper Warning #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cted due to an errror
🦋 Changeset detectedLatest commit: 586183c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
DominicGBauer
approved these changes
Sep 2, 2024
rkistner
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A debug log is printed if using Android and the HTTP network request failed to resolve in 30 seconds. This is usually due to the Flipper debug tool causing HTTP stream requests to never resolve (or reject). The timeout for this log was cleared if the HTTP request resolves.
The Flipper warning log would still show after the timeout expired even if the network request rejected. This updates the logic to clear the timeout if the HTTP request rejects or resolves.
Testing
Verified that the timeout is cleared if the request resolves or rejects. HTTP streaming also functions normally.