Skip to content

[Fix] Upload crud delay #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2023
Merged

[Fix] Upload crud delay #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smart-suns-divide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@journeyapps/powersync-sdk-common': patch
---

Fixed streaming sync implementation not delaying CRUD upload retries.
7 changes: 6 additions & 1 deletion packages/powersync-sdk-common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ export abstract class AbstractStreamingSyncImplementation extends BaseObserver<S
}
} catch (ex) {
this.updateSyncStatus(false);
await this.delayRetry();
this.isUploadingCrud = false;
break;
}
Expand Down Expand Up @@ -133,7 +134,7 @@ export abstract class AbstractStreamingSyncImplementation extends BaseObserver<S
this.logger.error(ex);
this.updateSyncStatus(false);
// On error, wait a little before retrying
await new Promise((resolve) => setTimeout(resolve, this.options.retryDelayMs));
await this.delayRetry();
}
}
}
Expand Down Expand Up @@ -309,4 +310,8 @@ export abstract class AbstractStreamingSyncImplementation extends BaseObserver<S
this.iterateListeners((cb) => cb.statusChanged?.(new SyncStatus(this.isConnected, this.lastSyncedAt)));
}
}

private async delayRetry() {
return new Promise((resolve) => setTimeout(resolve, this.options.retryDelayMs));
}
}
36 changes: 36 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2066,6 +2066,42 @@
"@types/yargs" "^17.0.8"
chalk "^4.0.0"

"@journeyapps/powersync-attachments@0.0.3":
version "0.0.3"
resolved "https://registry.npmjs.org/@journeyapps/powersync-attachments/-/powersync-attachments-0.0.3.tgz#9c33da5140edafeb5b054ced6a7365869e14633e"
integrity sha512-Aq0O7nFRfvxTddxzY4hJ7mWKl2oz/Ube8URZ+EbPo5rjLm3sTV+UKOZ54eS3bBqYjqAgeVUwCSphkWzs00BClQ==
dependencies:
"@journeyapps/powersync-sdk-common" "0.1.2"

"@journeyapps/powersync-react@0.1.1":
version "0.1.1"
resolved "https://registry.npmjs.org/@journeyapps/powersync-react/-/powersync-react-0.1.1.tgz#60d12b425a3d16d0f556f89998fb706bc0ba51bf"
integrity sha512-bAJDSsyXjE8dbLqGVaKp7UOD09T3piKS1/uYl1j0i/nZjLb1PV5IfBDrO7nzMUj9v38TpT3gW8FitcnnMMCkxw==
dependencies:
"@journeyapps/powersync-sdk-common" "0.1.2"

"@journeyapps/powersync-sdk-common@0.1.2":
version "0.1.2"
resolved "https://registry.npmjs.org/@journeyapps/powersync-sdk-common/-/powersync-sdk-common-0.1.2.tgz#309bdb049d2939f05a06d20ab526de39a8539895"
integrity sha512-lQExqszNY7bK8HYlNDDsO2mtK2yb3mRAQPVOSMsgo1ssQmxMP9RGdII+HvPkEIprcEkmNogS8AhY6QN/U7wq8w==
dependencies:
async-mutex "^0.4.0"
can-ndjson-stream "^1.0.2"
event-iterator "^2.0.0"
js-logger "^1.6.1"
lodash "^4.17.21"
object-hash "^3.0.0"
uuid "^3.0.0"

"@journeyapps/powersync-sdk-react-native@0.1.2":
version "0.1.2"
resolved "https://registry.npmjs.org/@journeyapps/powersync-sdk-react-native/-/powersync-sdk-react-native-0.1.2.tgz#8f44e37e9bf5397228c0ca8c09770c6919795ea8"
integrity sha512-SA3qdRQOizcYyOzeGPaH838Kr+jSmEU+GcOo8Ze9u6gsY6zazwQyyCUJGqOgyMqnOTXGoX7HGNXXacVenLbLkA==
dependencies:
"@journeyapps/powersync-react" "0.1.1"
"@journeyapps/powersync-sdk-common" "0.1.2"
async-lock "^1.4.0"

"@journeyapps/react-native-quick-sqlite@0.1.1":
version "0.1.1"
resolved "https://registry.npmjs.org/@journeyapps/react-native-quick-sqlite/-/react-native-quick-sqlite-0.1.1.tgz#94145dba13b177f6aa42552754e56ecc3b2e7f17"
Expand Down