WatchedQuery Bug Fixes #713
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes several bugs and regressions introduced with Incrementally Watched Queries.
For background, see this Discord thread.
Updating Watched Query Settings
This addresses a race condition that could occur when
updateSettings
was called multiple times on the sameWatchedQuery
instance.The changes improve how
AbortController
lifecycles are managed, ensuring that updates from linked queries do not execute simultaneously.Previously, this could cause
isFetching
to briefly reportfalse
before toggling back totrue
when query parameters changed.React Hooks
In some cases,
isFetching
was reported asfalse
immediately after changing query parameters: before the query had actually executed. This made handling state inuseQuery
unreliable.This PR fixes the issue by applying the same approach that was previously implemented here.