chore: improve watch query #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicGBauer
changed the title
stevensJourney
previously approved these changes
Feb 19, 2025
stevensJourney
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current watch query is prone to inconsistent issues. This issue arises because the SQLite commit hook transaction notifies listeners about a change before the transaction has been fully committed. Therefore a table update would fire and cause the watch query to re-run before the actual commit had taken place. This could result in timing issues as the query may not yet return with the new data as the transaction commit had not been completed.
This PR resolves this issue by accumulating table changes and only emitting a table update (which results in the watch query re-running) once a
writeTransactionorexecutehas been completed.The recommendation from this PR https://github.com/powersync-ja/powersync-kotlin/pull/121/files is also included.
There was an issue with the JDBC driver as it starts with index 1 as opposed to 0. A fix for this has also been included.