Update Schema #154
Merged
Update Schema #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
previously approved these changes
Mar 27, 2025
core/src/commonMain/kotlin/com/powersync/db/internal/ConnectionPool.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#150 recently raised an issue with local only tables.
This was caused by incorrect serialisation of the provided
Schema. Specifically, the JSON payload for the schema supplied camel case field names forlocalOnly,insertOnlyandviewNameinstead of the requiredlocal_only,insert_only, andview_nameparameters.This PR updates the serialisation method to use the correct serial name when serialising the schema.
We recently got some feedback that
@Serializableshould be avoided for public interfaces/classes as these can increase the objective C header size for the Swift SDK. This PR also removes@Serializablefrom the Schema definition classes. We still use@Serializablefor other public classes, this is not addressed in this PR. In practice the changes here make the header file about 25 lines smaller.This PR also adds the ability to update the schema after a PowerSync client has been initialised.