Fix some logging issues #242
Conversation
|
Ok, seems that I shouldn't try to beat this lint without support from IDEA, but it doesn't work until the project is built, which it doesn't. |
There was a problem hiding this comment.
I agree with these changes, and looking at an example app it's nice that we now have a proper tag for PowerSync-related logs 👍
I didn't run any tests because I couldn't wait for the project to build. On my Intel Core Ultra 7 14x4.8 GHz with 32 GB of RAM the build didn't finish in 45 minutes, it's already late here and I should go to bed soon.
That's probably an issue with our build setup and not with your machine. Do you remember a specific task taking too long (or was it just stuck downloading dependencies)? We build or SDK on GH actions which is a lot slower but still seems to work. So I assume there may be something locking up here.
It was just the initial Gradle sync, if I remember correctly it is called "Build model". It was not stuck, it just kept downloading and building, and so on and so on. |
| * Generates a logger with the appropriate severity level based on the build type | ||
| * if no Logger is provided. | ||
| */ | ||
| public fun generateLogger(logger: Logger?): Logger { |
There was a problem hiding this comment.
This is currently being used by the Swift SDK (which wraps this module). We can still remove it from this module, but we'd need to move it to the PowerSyncKotlin module in order for the Swift SDK to continue using it.
Hey guys,
This pull request addresses some logging issues I spotted long ago, but today I wanted to have certain PowerSync logs in my common app log, and this was time to fix them.
PowerSynctag to the logs – as now the library has its own default logger instance, it deserves a tag;generateLogger()global public method – it really seemed like a method meant to be used internally as it is quite specific, but even internally it is no longer needed.I didn't run any tests because I couldn't wait for the project to build. On my Intel Core Ultra 7 14x4.8 GHz with 32 GB of RAM the build didn't finish in 45 minutes, it's already late here and I should go to bed soon.