Make 404 errors consistent with other error responses #305
+61
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sync service has custom error types used to respond with error descriptions, like:
When requesting an endpoint that doesn't exist, the sync service also responds with an error. That response has an incompatible structure though:
That response manages to crash the error handler in the Dart SDK, leading to a confusing error message there.
This PR installs a custom 404 handler on fastify to ensure the responses are consistent.