Skip to content

Conversation

simolus3
Copy link
Contributor

@simolus3 simolus3 commented Sep 4, 2025

In sync requests, requesting a stream with parameters: null should be allowed (null is the canonical representation of not providing parameters and should be used over {} for consistency). Unfortunately, the sync service rejects those values when parsing requests (internally, null is allowed and covered by tests - it's just the outermost layer that breaks this).

This fixes the RequestedStreamSubscription codec to:

  • enforce the parameters value being set
  • allow null.

@simolus3 simolus3 requested a review from rkistner September 4, 2025 15:52
Copy link

changeset-bot bot commented Sep 4, 2025

🦋 Changeset detected

Latest commit: 13ee8cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@powersync/service-core Patch
@powersync/service-image Patch
@powersync/service-core-tests Patch
@powersync/service-module-core Patch
@powersync/service-module-mongodb-storage Patch
@powersync/service-module-mongodb Patch
@powersync/service-module-mysql Patch
@powersync/service-module-postgres-storage Patch
@powersync/service-module-postgres Patch
test-client Patch
@powersync/service-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@simolus3 simolus3 merged commit f400b0f into main Sep 4, 2025
21 checks passed
@simolus3 simolus3 deleted the stream-parameters-allow-null branch September 4, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants