Allow null
as stream parameter
#357
Merged
+51
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sync requests, requesting a stream with
parameters: null
should be allowed (null
is the canonical representation of not providing parameters and should be used over{}
for consistency). Unfortunately, the sync service rejects those values when parsing requests (internally,null
is allowed and covered by tests - it's just the outermost layer that breaks this).This fixes the
RequestedStreamSubscription
codec to:parameters
value being setnull
.