Fix unecessary schema changes #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkistner
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect calls to
powersync_replace_schema(?)with a schema that is already present in the database to be a noop. Unfortunately, version 0.3.13 had a regression here because theCREATE TRIGGERstatement for deletes includes a trailing semicolon. This semicolon is not added tosqlite_schema(which is the source we use for diffs to determine which views to update), meaning that all views are re-created every time.This was caught by a Dart CI failure, so I've copied the test into this repository. I've also bumped the version number so that we can do another release to get this out quickly.