Skip to content

Fix broken local uri's when relaunching the app #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2025
Merged

Fix broken local uri's when relaunching the app #74

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21e8426
Fix broken localUri's for attachments that do exist
jonkan Sep 2, 2025
5b27b37
Clear any local uri's for archived attachments
jonkan Sep 2, 2025
7c64b47
Run verify attachments immediately when creating the AttachmentQueue
jonkan Sep 8, 2025
92ff761
Merge branch 'main' into fix-broken-local-uris
stevensJourney Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion Sources/PowerSync/attachments/AttachmentQueue.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,16 @@ public actor AttachmentQueue: AttachmentQueueProtocol {
errorHandler: self.errorHandler,
syncThrottle: self.syncThrottleDuration
)

Task {
do {
try await attachmentsService.withContext { context in
try await self.verifyAttachments(context: context)
}
} catch {
self.logger.error("Error verifying attachments: \(error.localizedDescription)", tag: logTag)
}
}
}

public func getLocalUri(_ filename: String) async -> String {
Expand Down Expand Up @@ -463,7 +473,15 @@ public actor AttachmentQueue: AttachmentQueueProtocol {
continue
}

if attachment.state == AttachmentState.queuedUpload {
let newLocalUri = await getLocalUri(attachment.filename)
let newExists = try await localStorage.fileExists(filePath: newLocalUri)
if newExists {
// The file exists but the localUri is broken, lets update it.
// E.g. this happens in simulators that change the path to the app's sandbox.
updates.append(attachment.with(
localUri: newLocalUri
))
} else if attachment.state == AttachmentState.queuedUpload || attachment.state == AttachmentState.archived {
// The file must have been removed from the local storage before upload was completed
updates.append(attachment.with(
state: .archived,
Expand Down