Improve compatibility check for core extension #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
commented
Mar 5, 2025
rkistner
previously approved these changes
Mar 5, 2025
|
Just need to update the tests to use the new extension |
rkistner
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening databases, we check whether the version of the core extension we've loaded is compatible with our Dart SDK. This check was not updated for the update to bucket priorities, allowing SDK versions
<0.3.11to be used. This breaks immediately afterwards when selecting fromps_sync_state.This updates the version check to the new minimum version and refactors the check to make minimum and maximum versions easier to update the future.
When the version check fails on the web (the most likely cause since we expect
powersyncandpowersync_flutter_libsto be updated as one, but require users to update our WebAssembly files manually), this also improves the error message to point to the docs explaining how to update these assets.Resolves #248.