Skip to content

Conversation

davidmartos96
Copy link
Contributor

Fixes tests with the Rust core sync implementation. Not sure if this is needed, or if the Rust part needs to be aware of the data possibly coming as a JSON object instead of String.

Copy link
Contributor

@simolus3 simolus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The Rust core implementation doesn't have to be aware of directly-encoded data objects (that's a deprecated representation, our current SDKs always request the sync service to encode data). So fixing the tests is correct here.

@simolus3 simolus3 merged commit 01684dc into powersync-ja:rust-core-sync Jun 9, 2025
@davidmartos96 davidmartos96 deleted the fix_rust_sync_tests branch June 9, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants